[alsa-devel] [PATCH 3/10] sound/atmel/abdac.c: fix error return code

Julia Lawall julia.lawall at lip6.fr
Sun Apr 5 14:12:46 CEST 2015


Please ignore. Wrong patch set.

On Sun, 5 Apr 2015, Julia Lawall wrote:

> From: Julia Lawall <Julia.Lawall at lip6.fr>
> 
> Initialize retval before returning from a failed call to ioremap.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> (
> if at p1 (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret at p1 = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> 
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr>
> 
> ---
>  sound/atmel/abdac.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c
> index 98554f4..277ebce 100644
> --- a/sound/atmel/abdac.c
> +++ b/sound/atmel/abdac.c
> @@ -452,6 +452,7 @@ static int __devinit atmel_abdac_probe(struct platform_device *pdev)
>  	dac->regs = ioremap(regs->start, resource_size(regs));
>  	if (!dac->regs) {
>  		dev_dbg(&pdev->dev, "could not remap register memory\n");
> +		retval = -ENOMEM;
>  		goto out_free_card;
>  	}
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


More information about the Alsa-devel mailing list