[alsa-devel] [PATCH v6 05/10] ASoC: Intel: mrfld: add DSP core controls

[Vinod Koul]

On Thu, Sep 18, 2014 at 10:28:52AM -0700, Mark Brown wrote:
> On Thu, Sep 18, 2014 at 11:42:37AM +0530, Vinod Koul wrote:
> > On Wed, Sep 17, 2014 at 12:37:06PM -0700, Mark Brown wrote:
> 
> > > This doesn't really answer my concern - what happens if we're already
> > > active and making a change?
> 
> > Since this is specfic to BE (SSP) port, the DSP FW doesnt allow us to reconfigure
> > the slots when it is active. These will take effect next time the BE
> > restarts.
> 
> > Yes not ideal but thats something we have to live with!
> 
> That's fine but in that case I would expect to see an error returned to
> userspace rather than just silently ignoring what it's doing until the
> next time we start a stream, or at the very least some sort of warning
> generated.  Silently ignoring things isn't great especially with no
> comments in the code, it ends up looking like a bug.
Error to usermode wont be apt as we accept the value and due to constraint
the value is applied at next BE start.

Yes definately makes sense to put a comment about this. Will update that

Thanks
-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140919/2de6c088/attachment-0001.sig>