[alsa-devel] [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property

Timur Tabi timur at tabi.org
Fri Sep 19 02:29:32 CEST 2014


Nicolin Chen wrote:
> Thank you for the comments. Then we may use compatible check for
> P1022 and MPC8610 to limit their DAI formats.
>
> For the property, do you agree to modify it like this:
>
> - fsl,mode:         The operating mode for the AC97 interface only.
>                      "ac97-slave" - AC97 mode, SSI is clock slave
>                      "ac97-master" - AC97 mode, SSI is clock master
>                      (There's no need for other DAI format like I2S
> 		    mode to engage this property.)
>
> And how about this patch? I'm personally okay with this change.
> We may also send an extra patch to refine the document after the
> agreement's done.

You can't just redefine a property, because that breaks backwards 
compatibility with older device trees or older kernels.


More information about the Alsa-devel mailing list