[alsa-devel] [PATCH v6 03/10] ASoC: Intel: mrfld: add the gain controls

[Mark Brown]

On Tue, Sep 09, 2014 at 03:11:26PM +0530, Subhransu S. Prusty wrote:

> +	{ SST_GAIN_KCONTROL_INT(SST_CONTROL_NAME(xpname, xmname, xinstance, "rampduration"), \

> +	{ SST_GAIN_KCONTROL_BOOL(SST_CONTROL_NAME(xpname, xmname, xinstance, "mute"), \

> +	{ SST_GAIN_KCONTROL_TLV(SST_CONTROL_NAME(xpname, xmname, xinstance, "volume"), \

The macros in here look like they're all going to generate non-standard
control names - volume controls should be " Volume", booleans should be
" Switch" and I'd expect ramp delay to be written idiomatically as "
Ramp Delay".  This will confuse standard userspaces which rely on the
control names.

I've got a feeling this may be an issue with the previous patch as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140916/9e249a2d/attachment.sig>