[alsa-devel] [PATCH] ASoC:simple-card: Add multi-CODEC support

Jean-Francois Moine moinejf at free.fr
Wed Sep 10 18:06:39 CEST 2014


On Wed, 10 Sep 2014 13:43:06 +0200
Benoit Cousson <bcousson at baylibre.com> wrote:

> > +		codec at 0 {
> > +			sound-dai = <&hdmi 0>;
> > +		};
> > +		codec at 1 {
> > +			sound-dai = <&spdif_codec>;
> >   		};  
> 
> I don't have strong opinion on that, but in my case, I was considering 
> using a simple list instead of several nodes.
> I don't like having to add fake address just to ensure uniqueness.
> 
> Something like that:
> 
>   sound-dais = <&spdif_codec 1>, <&hdmi 0>;

You are right, this would be simpler (I did not see that there could be
phandle's with different cell sizes in a list).

> That being said, it will require changing the name with a plural form, 
> and ensuring we have the same number of parameters for each codec.

But I don't think that changing the name could be useful: the treatment
is exactly the same and, as a result, all CODEC DAIs go to the DAI
list of the DAI link.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/


More information about the Alsa-devel mailing list