[alsa-devel] [PATCH v5 03/12] ALSA: control: Add init callback for kcontrol

Vinod Koul vinod.koul at intel.com
Wed Sep 10 10:05:31 CEST 2014


On Tue, Sep 09, 2014 at 12:44:25PM +0100, Mark Brown wrote:
> On Mon, Sep 08, 2014 at 01:38:07PM +0530, Vinod Koul wrote:
> 
> Please (as I'm sure has been pointed out before) fix your mailer to word
> wrap within paragraphs.
Oops, i though I had set mutt to fix it after you pointed out last time,
will check again.

> 
> > On Mon, Sep 08, 2014 at 10:04:42AM +0200, Takashi Iwai wrote:
> 
> > > For example, you can embed an init flag into your record and call the
> > > initializer in get/put callback if not called yet.
> 
> > Yes but that would involve open coding in all control hanlers for the
> > driver :
> 
> > if (!initialized) allocate_control_mem();
> 
> > This approach was done earlier (checking in info) and flaged off by
> > Mark. It make better to have these handled in the framework.
> 
> No, that's not the problem I identified.  The bug you had was that the
> driver was initialising the data in only the info callback and would just
> fail if someone decided to call another callback first.
Yes and during the discussed we wanted to handle it in framework leading to
init callback.

Nevertheless we are moving it back to driver while fixing the bug you
pointed.

Thanks
-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140910/774e70a9/attachment.sig>


More information about the Alsa-devel mailing list