[alsa-devel] [PATCH 7/9] ASoC: Intel: move PCI probe to a seprate file

Mark Brown broonie at kernel.org
Thu Oct 30 18:31:12 CET 2014


On Thu, Oct 30, 2014 at 06:07:00PM +0100, Takashi Iwai wrote:
> Vinod Koul wrote:

> > snd-intel-sst-pci-y += sst-intel-core.o sst_pci.o
> > snd-intel-sst-acpi-y += st-intel-core.o sst_acpi.o

> Kbuild doesn't allow this syntax, AFAIK.

I've not followed the whole discussion but why not just have the core
code as a separate module, this seems like an awful lot of trouble for
something that's normally straightforward...

> > well both can be compile tested and we will put in symbols about limitation
> > of having bpth apci and pci as built-in or module.

> No, the point is that the exclusiveness in Kconfig level gives more
> demerits.  This makes impossible to build the both codes in a single
> shot, which makes also impossible to cover wider build tests, etc.
> My concern isn't about the actual operation but about testing.

> That is: don't try to side step such a build issue.  I bet it'll
> strike back later.  Better to keep rather the simple and common
> approach other drivers take.

Right.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141030/8a241719/attachment-0001.sig>


More information about the Alsa-devel mailing list