[alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

Mauro Carvalho Chehab m.chehab at samsung.com
Sat Oct 25 12:57:42 CEST 2014


Hi,

Sorry to enter into this thread so late. Last week was a full week, due to the
4 conferences I paticiapated, and last week I needed to fill lots of trip
reports. Also, I have another trip to give two speeches.

Em Tue, 21 Oct 2014 11:32:10 -0600
Shuah Khan <shuahkh at osg.samsung.com> escreveu:

> Here is what I propose for patch v3:
> - make it a module under media
> - collapse tuner and audio tokens into media token

I'm a little skeptical about this. Merging tuner and audio tokens seems
weird on my eyes, as there are actually two different hardware resources
we need to lock, and we may be locking them on different places.

> - change names (get rid of abbreviated tkn stuff)
> - Make other changes Takashi/Lars pointed out in pcm
> - hold token in pcm open/close

I agree with Hans here: blocking at open/close will likely cause too
much harm, as PA is unable to give an special treatment to media devices.

Ok, a media-aware logic at PA wouldn't be technically hard to be added,
but not sure if the PA maintainers would even consider this hypothesis.

> - add a bitfield to struct v4l2_fh to handle
>   the v4l specific multiple ownership cases.
> - v4l-core and au0828-videp patches will see changes.
> - dvb patch should still be good (crossing fingers)

Regards,
Mauro


More information about the Alsa-devel mailing list