[alsa-devel] [PATCH v4 3/7] ASoC: Intel: sst - add pcm ops handling

Vinod Koul vinod.koul at intel.com
Fri Oct 17 13:35:23 CEST 2014


On Fri, Oct 17, 2014 at 02:07:10PM +0200, Mark Brown wrote:
> On Thu, Oct 16, 2014 at 08:00:15PM +0530, Vinod Koul wrote:
> 
> > +int free_stream_context(struct intel_sst_drv *ctx, unsigned int str_id)
> > +{
> > +	struct stream_info *stream;
> > +	int ret = 0;
> > +
> > +	stream = get_stream_info(ctx, str_id);
> > +	if (stream) {
> > +		/* str_id is valid, so stream is alloacted */
> > +		ret = sst_free_stream(ctx, str_id);
> > +		if (ret)
> > +			sst_clean_stream(&ctx->streams[str_id]);
> > +		return ret;
> > +	}
> > +	return ret;
> > +}
> 
> I keep on asking for this to print an error on double frees.
Okay looks like I missed this instance though I do rember fixed another one.
I will fix it up.

> 
> > +/*
> > + * sst_get_sfreq - this function returns the frequency of the stream
> > + *
> > + * @str_param : stream params
> > + */
> > +int sst_get_num_channel(struct snd_sst_params *str_param)
> 
> Cut'n'paste error in the kerneldoc.
Oops will fix

-- 
~Vinod

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141017/c9130dc8/attachment-0001.sig>


More information about the Alsa-devel mailing list