[alsa-devel] [PATCH] ASoC: mc13783: Ensure we only try to dereference valid of_nodes

Takashi Iwai tiwai at suse.de
Wed Oct 8 18:12:10 CEST 2014


At Wed, 8 Oct 2014 16:50:15 +0100,
Mark Brown wrote:
> 
> On Wed, Oct 08, 2014 at 05:06:15PM +0200, Takashi Iwai wrote:
> 
> > I'd move the declaration of np into if block, too, so that it won't be
> > referred in other places.
> 
> I generally dislike that style outside of very large functions; it's not
> typical for C.

OK, it's a matter of taste.  A typical bikeshed topic, we can spend
hours about this :)


Takashi


More information about the Alsa-devel mailing list