[alsa-devel] [GIT PULL] ASoC updates for v3.18

Takashi Iwai tiwai at suse.de
Tue Oct 7 20:15:08 CEST 2014


At Tue, 07 Oct 2014 20:07:38 +0200,
Takashi Iwai wrote:
> 
> At Tue, 7 Oct 2014 14:53:12 -0300,
> Fabio Estevam wrote:
> > 
> > Hi Mark/Takashi,
> > 
> > On Tue, Oct 7, 2014 at 2:14 PM, Mark Brown <broonie at kernel.org> wrote:
> > > On Mon, Oct 06, 2014 at 02:37:53PM +0200, Takashi Iwai wrote:
> > >> Mark Brown wrote:
> > >
> > >> However, this resulted in a few new build warnings, and some of them
> > >> look correctly reported.
> > >
> > >> *  sound/soc/codecs/mc13783.c:787:13: warning: 'np' may be used uninitialized in this function [-Wuninitialized]
> > >
> > >> The call of_node_put(np) is done unconditionally even for non-NULL
> > >> pdata where np isn't initialized.  This may lead to a real crash.
> > 
> > Calling of_node_put() with NULL as an argument does not cause crashes.
> > Please check:
> > http://patchwork.ozlabs.org/patch/377930/
> 
> Unless np is uninitialized, it points to a random address.

Oops,

s/uninitialized/initialized/


Takashi


More information about the Alsa-devel mailing list