[alsa-devel] [PATCH 2/4] ASoC: eukrea-tlv320: Fix of_node_put() call with uninitialized object

Takashi Iwai tiwai at suse.de
Tue Oct 7 19:39:57 CEST 2014


At Tue, 7 Oct 2014 18:18:00 +0100,
Mark Brown wrote:
> 
> On Tue, Oct 07, 2014 at 06:19:52PM +0200, Takashi Iwai wrote:
> 
> > -	struct device_node *ssi_np, *codec_np;
> > +	struct device_node *ssi_np = NULL, *codec_np;
> 
> As well as the NULL thing mixing initialized and unintialized things in
> one declaration is something that's normally avoided.

I thought of that, too.  For simplicity, we can do NULL
initializations for both, of course, if you prefer.


Takashi


More information about the Alsa-devel mailing list