[alsa-devel] [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

D Krishna Mohan krishna.md at samsung.com
Wed Nov 26 09:56:07 CET 2014


FYI your Suggestion was:
"You need to add an ifdef around the struct (or perhaps a __maybey_unused 
type annotation if there's something suitable) for such configurations."

Following your suggestion I have sent a patch 
(187024b36c635bd454c1b1587b58c9439d3a46ad on your git, branch: rt5631 ) 
using ifdef which you have already applied.
Since there are more suggestion asking for second (__maybe_unused) method, I 
have sent another patch for which below is the link.

You may be applying the second patch on the already applied first patch. so 
I request you to apply only second patch in place of first and abandon first 
patch.


Already applied patch in your git: 
http://www.spinics.net/lists/linux-samsung-soc/msg39044.html  [pls remove 
this and instead apply the below mentioned patch]
Patch to apply: 
http://www.spinics.net/lists/linux-samsung-soc/msg39465.html


-Krishna

--------------------------------------------------
From: "Mark Brown" <broonie at kernel.org>
Sent: Monday, November 24, 2014 10:34 PM
To: "Krishna Mohan Dani" <krishna.md at samsung.com>
Cc: <linux-samsung-soc at vger.kernel.org>; 
<linux-arm-kernel at lists.infradead.org>; <alsa-devel at alsa-project.org>; 
<kgene.kim at samsung.com>; "Claude Youn" <claude.youn at gmail.com>
Subject: Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is 
disabled

On Mon, Nov 24, 2014 at 04:52:42PM +0530, Krishna Mohan Dani wrote:
> Fixes the following compilation warning:
> Warning: 'rt5631_i2c_dt_ids' defined but not used - when DT is not used.

This doesn't apply, please check and resend.
 



More information about the Alsa-devel mailing list