[alsa-devel] [PATCH 0/1] Add big-endian DSD sample formats and fix XMOS DSD sample format

[Takashi Iwai]

At Fri, 21 Nov 2014 14:08:23 +0200 (EET),
Jussi Laako wrote:
> 
> On Fri, 21 Nov 2014, Takashi Iwai wrote:
> 
> > At Fri, 21 Nov 2014 12:00:26 +0200,
> > Jussi Laako wrote:
> > > 
> > > Resend, previous had non matching subject for cover letter vs patch.
> > > 
> > > This patch fixes XMOS DSD sample format to DSD_U32_BE and also adds
> > > DSD_U16_BE and DSD_U32_BE sample formats.
> > > 
> > > Jussi Laako (1):
> > >   Add big-endian DSD sample formats and fix XMOS DSD sample format
> > 
> > The changes there look good (supposing you tested with the real
> > device).  Since DSD_U32 was added in 3.18-rc1, I think we can put this
> > as a fix for 3.18.
> > 
> > Could you submit the patch for alsa-lib as well?
> 
> I sent two patches, one is for kernel and another one is for alsa-lib.

Ah, I missed it.  Then please give a proper prefix to identify that.

Also, the patch without any proper description looks wrong.  What you
wrote in patch 0 should be put into patch 1.  Also better to mention
which devices were actually tested.

Last but not least, we don't need any cover letter for a single
patch.  Just describe the patch itself well.

Could you again resend with proper descriptions?


thanks,

Takashi


> I have tested the patches on top of Ubuntu Trusty using iFi iDSD Nano and 
> everything works.
> 
> 
> Best regards,
> 
> 	- Jussi
>