[alsa-devel] [PATCH 0/9] ASoC: QCOM: Add support for ipq806x SOC

Mark Brown broonie at kernel.org
Thu Nov 20 10:51:00 CET 2014


On Wed, Nov 19, 2014 at 02:16:10PM -0600, Kumar Gala wrote:

Kumar, as I keep saying please fix your mailer to word wrap within
paragraphs.

> Some general comments, you shouldn’t have gerrit Change-Id’s in commit

Indeed.

> messages, the Kconfig/Makefile changes should be part of the patch
> that adds the code associated with them.

No, it's totally fine for a large new driver like this that's split over
many commits to add the Kconfig and Makefile at the end - there is no
value in trying to split them up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141120/dbe5cd2c/attachment-0001.sig>


More information about the Alsa-devel mailing list