[alsa-devel] [PATCH 2/2] ASoC: wm9712/wm9713: Replace virtual registers with custom put/get callbacks

Charles Keepax ckeepax at opensource.wolfsonmicro.com
Sat Nov 8 13:43:12 CET 2014


On Fri, Nov 07, 2014 at 10:52:56AM +0100, Lars-Peter Clausen wrote:
> On 11/03/2014 07:33 PM, Lars-Peter Clausen wrote:
>> The wm9712/wm9713 has separate mixers for the left and the right channel,
>> but the inputs to the mixers are enabled/disabled by the same control.
>> Currently this is implemented by the driver by registering two virtual
>> controls for each physical control, one for the left mixer and one for the
>> right mixer.
>>
>> Using virtual registers will no longer work when the driver has
>> been converted to regmap. This patch converts the driver to use controls
>> with custom put/get callbacks instead which implement the logic making sure
>> that the physical control is unmuted when either the left or the right
>> control is unmuted.
>>
>> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
>
> Hi Charles,
>
> Given your usual fast responses on patches I'm suspecting that this one 
> may have been lost. If not I apologize for the noise.
>
> Thanks,
> - Lars

Apologies for that, it must have come in on a busy morning and
then I forgot to come back to it.

All looks good to me and seems Mark has applied it now.

Thanks,
Charles


More information about the Alsa-devel mailing list