[alsa-devel] [PATCH v3 2/2] ASoC: simple-card: add multi-CODECs in DT

[Mark Brown]

On Tue, Nov 04, 2014 at 11:21:46AM +0100, Jean-Francois Moine wrote:

This looks like it combines some refactoring to split out some of the
DAI node parsing code with some new code.  It's quite hard to read
what's going on here, separating the code motion and the new code would
make life a lot easier, I've stared at it for a bit and I'm still not
100% sure it's doing everything it's supposed to be.

> -Example 2 - many DAI links:
> +Example 2 - many DAI links and multi-CODECs:

This would be a lot easier to read if the change didn't completely
rewrite the example but just added the thing it wants to add an example
of; the example may be drawn from a real system but that's not the
point.

>  	} else {
> -		clk = of_clk_get(args.np, 0);
> +		clk = of_clk_get((struct device_node *) dai_np, 0);

Adding this cast looks suspicous - why?  As far as I can tell the
original code didn't need one.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141107/ea896649/attachment.sig>