[alsa-devel] [PATCH v3 6/6] ASoC: Intel: Add Merrifield machine driver

Vinod Koul vinod.koul at intel.com
Thu Nov 6 14:18:35 CET 2014


On Thu, Nov 06, 2014 at 12:51:19PM +0000, Mark Brown wrote:
> On Tue, Nov 04, 2014 at 04:25:20PM +0530, Vinod Koul wrote:
> 
> > +static int mrfld_wm8958_set_clk(struct snd_soc_dai *codec_dai)
> > +{
> > +	int ret = 0;
> > +	struct snd_soc_card *card = codec_dai->card;
> > +
> > +	ret = snd_soc_dai_set_tdm_slot(codec_dai, 0xf0, 0xf0, 4, 24);
> > +	if (ret < 0) {
> > +		dev_err(card->dev, "can't set codec pcm format %d\n", ret);
> > +		return ret;
> > +	}
> 
> We already set this on init - why do we need to set it each time here
> too?
It is not required, will remove.

--
~Vinod 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20141106/2afb40ec/attachment.sig>


More information about the Alsa-devel mailing list