[alsa-devel] [PATCH] ASoC:rt286: set combo jack by dmi

[Jie, Yang]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Thursday, November 06, 2014 1:23 AM
> To: bardliao at realtek.com
> Cc: lgirdwood at gmail.com; alsa-devel at alsa-project.org; lars at metafoo.de;
> flove at realtek.com; oder_chiou at realtek.com; Jie, Yang
> Subject: Re: [PATCH] ASoC:rt286: set combo jack by dmi
> 
> On Wed, Nov 05, 2014 at 01:09:26PM +0800, bardliao at realtek.com wrote:
> 
> > +static struct dmi_system_id intel_platform[] __initdata = {
> > +	{
> 
> This is fine but can you please rename the variable from intel_platform to
> something more meaningful like the name of the reference design these are
> derived from or something?  That way if we need to add some other quirk
> (and I guess we will) we won't have to rename this table - I guess anything
> that's using a DMI quirk will be some Intel based platform.
[Keyon] maybe we can use something like 'combo_jack_platform'?