[alsa-devel] ALSA: echoaudio: remove all snd_printk

[Takashi Iwai]

At Tue, 4 Nov 2014 19:01:56 +0300,
Dan Carpenter wrote:
> 
> Hello Sudip Mukherjee,
> 
> The patch b5b4a41b3929: "ALSA: echoaudio: remove all snd_printk" from
> Nov 3, 2014, leads to the following static checker warning:
> 
> 	sound/pci/echoaudio/echoaudio.c:1908 snd_echo_free()
> 	error: dereferencing freed memory 'chip'
> 
> sound/pci/echoaudio/echoaudio.c
>   1905          /* release chip data */
>   1906          free_firmware_cache(chip);
>   1907          kfree(chip);
>                 ^^^^^^^^^^^
>   1908          dev_dbg(chip->card->dev, "Chip freed.\n");
>                         ^^^^^^^^^^
> 
> We have lots of printks in this function.  We could just delete them all
> and no one would care.  These days you can get the same information from
> ftrace.

Yep, maybe it's a wiser choice.  Sudip, care to send a clean up patch?


thanks,

Takashi