[alsa-devel] [PATCH] ASoC: rsnd: fixup SSI interrupts style of DeviceTree

Ben Dooks ben at trinity.fluff.org
Fri May 30 12:53:21 CEST 2014

On Fri, May 30, 2014 at 03:43:50AM -0700, Kuninori Morimoto wrote:
> Hi Ben
> Thank you for your feedback
> > > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > > 
> > > Current SSI interrupts has been set to each port.
> > > But it is too ugly style.
> > > SSI interrupts will be listed under
> > > rcar_sound,ssi node by this patch
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > > ---
> (snip)
> > This looks like a backward step, especially as we use the ssiX
> > blocks for DMA too.
> > 
> > Also, please just stop playing around with this stuff, other people
> > are trying to use this code and changing it without a good technical
> > reason is causing difficulty.
> Hmm...
> This driver is still under developing.
> And it is very difficult for me to care about out-of-tree Linux.

Ok, but we really need to keep in mind that the DT should be kept as
stable as possible. We may be out of tree at the moment, but we are
trying our best to keep track and feed back our work. This is not
helped if we have to do these changes when re-basing.

In my view this change does not help the readability, as we now have
a large block of interrupts, where before we could easily work out
which interrupt was mapped to which SSI.

Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

More information about the Alsa-devel mailing list