[alsa-devel] [PATCH 02/12] firewire-lib: Fix sparse warning of incorrect type in assignment

Takashi Sakamoto o-takashi at sakamocchi.jp
Tue May 27 17:14:37 CEST 2014


__be32 value should not be assigned directly to bool value.

Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
---
 sound/firewire/cmp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/firewire/cmp.c b/sound/firewire/cmp.c
index d31a403..ba8df5a 100644
--- a/sound/firewire/cmp.c
+++ b/sound/firewire/cmp.c
@@ -164,7 +164,9 @@ int cmp_connection_check_used(struct cmp_connection *c, bool *used)
 			c->resources.unit, TCODE_READ_QUADLET_REQUEST,
 			pcr_address(c), &pcr, 4, 0);
 	if (err >= 0)
-		*used = (pcr & cpu_to_be32(PCR_BCAST_CONN | PCR_P2P_CONN_MASK));
+		*used = !!(pcr & cpu_to_be32(PCR_BCAST_CONN |
+					     PCR_P2P_CONN_MASK));
+
 	return err;
 }
 EXPORT_SYMBOL(cmp_connection_check_used);
-- 
1.8.3.2



More information about the Alsa-devel mailing list