[alsa-devel] [PATCH 1/2] ASoC: max98090: Add master clock handling
broonie at kernel.org
Thu May 22 12:30:39 CEST 2014
On Thu, May 22, 2014 at 02:47:07PM +0530, Tushar Behera wrote:
> + max98090->mclk = devm_clk_get(codec->dev, "mclk");
> + if (!IS_ERR(max98090->mclk))
> + clk_prepare_enable(max98090->mclk);
Ths doesn't handle deferred probe, we need to at least return an error
if we get -EPROBE_DEFER.
It'd also be better to move the enabling to set_bias_level() if possible
(I don't know if the clock is needed for register access) though less
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel