[alsa-devel] [PATCH v2 1/2] ASoC: samsung: s3c24{xx, 12}-i2s: port to use generic dmaengine API

Vasily Khoruzhick anarsoul at gmail.com
Wed May 21 12:53:44 CEST 2014


On Wed, May 21, 2014 at 1:49 PM, Mark Brown <broonie at kernel.org> wrote:
> On Wed, May 21, 2014 at 09:42:21AM +0300, Vasily Khoruzhick wrote:
>> On Wed, May 21, 2014 at 1:19 AM, Mark Brown <broonie at kernel.org> wrote:
>> > On Tue, May 20, 2014 at 11:26:08PM +0300, Vasily Khoruzhick wrote:
>> >> Use dmaengine instead of legacy s3c24xx DMA API for s3c24xx and s3c2412
>
>> > Do these depend on any other code or can they just be applied
>> > immediately?
>
>> For compile time everything is present, for runtime they depend on
>> cyclic transfers support for s3c24xx-dmac (already submitted).
>> Also s3c24xx machines lack a platform device DMA (one-liner, not submitted yet).
>
> OK, in that case I think it might be better to hold off until either the
> DMA patches are merged or after the merge window (should be very soon)
> so that the driver still works in v3.16 - does that seem sensible?  The
> changes look OK, just a question of getting them merged safely.

Mark, legacy dma does not work for me as for 3.14, tried on h1940
(s3c2410) and on rx1950 (s3c2442).
So merging them won't break anything, it's already broken.

Regards
Vasily


More information about the Alsa-devel mailing list