[alsa-devel] [PATCH]: snd_seq_virmidi.c do not use running status for virmidi raw input

[Ralf Beck]

Am 07.05.2014 22:41, schrieb Clemens Ladisch:
> Ralf Beck wrote:
>> Rationale: Not every rawmidi alsa client (e.q. Bitwig) support 
>> running status on input. 
> Why does Bitwig use RawMIDI when it is only interested in the events? 
Its a closed source application. I'm not the author, so cannot change 
the application,
but i can change the virmidi code.
> Anyway, running status is part of the MIDI protocol. This is a bug in 
> Bitwig. 
I agree, but see above. I can't change Bitwig.

> And changing this setting might introduce regressions in other 
> programs that rely on the size of the raw MIDI data.
Being able to receive MIDI data with running status disabled is 
mandatory for a midi client.
So any client relying on running status always on would be buggy.

Would the patch be acceptable, if i make switching on/off of running 
status selectable by a module parameter
with the current behaviour being the default?
>> + vmidi->parser->nostat = 1; vmidi->seq_mode = rdev->seq_mode; 
> The patch formatting is still broken. 
I'll look into that.
> And please read Documentation/SubmittingPatches, I'l look into that.

I'l look into that.

Regards
Ralf
>
> Regards, Ralf