[alsa-devel] [PATCH 1/2] ASoC: Add support for CS42L56 CODEC

Mark Brown broonie at kernel.org
Tue May 6 03:24:22 CEST 2014

On Mon, May 05, 2014 at 03:09:08PM -0500, Brian Austin wrote:
> This patch adds support for the Cirrus Logic Low Power Stereo I2C CODEC

Applied, thanks.  A couple of minor issues it'd be good to look at

> +	SOC_ENUM("PCMA Swap", pcma_swap_enum),
> +	SOC_ENUM("PCMB Swap", pcmb_swap_enum),
> +	SOC_ENUM("ADCA Swap", adca_swap_enum),
> +	SOC_ENUM("ADCB Swap", adcb_swap_enum),

Can these be moved to DAPM?

> +	regcache_cache_bypass(cs42l56->regmap, true);

You shouldn't need to do this, if no default is provided regmap should
just go to hardware.

> +	dev_info(&i2c_client->dev, "Cirrus Logic CS42L56 ");
> +	dev_info(&i2c_client->dev, "Alpha Rev %X Metal Rev %X\n",
> +		 alpha_rev, metal_rev);

It's better to just put things on one line and ignore the line length
warnings from checkpatch - this makes the code more grepable.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140505/7ebb759e/attachment.sig>

More information about the Alsa-devel mailing list