[alsa-devel] [PATCH] ASoC: fsl_sai: Fix buggy configurations in trigger()

Mark Brown broonie at kernel.org
Mon Mar 31 20:20:38 CEST 2014


On Mon, Mar 31, 2014 at 07:39:22PM +0800, Nicolin Chen wrote:
> The current trigger() has two crucial problems:
> 1) The DMA request enabling operations (FSL_SAI_CSR_FRDE) for Tx and Rx are
>    now totally exclusive: It would fail to run simultaneous Tx-Rx cases.
> 2) The TERE disabling operation depends on an incorrect condition -- active
>    reference count that only gets increased in snd_pcm_open() and decreased
>    in snd_pcm_close(): The TERE would never get cleared.

Can you please check that this against my asoc-v3.15-4 tag - it doesn't
seem to apply there?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140331/7b7e4852/attachment.sig>


More information about the Alsa-devel mailing list