[alsa-devel] [PATCH v2] ASoC: davinci-mcasp: set up channel status bits for S/PDIF mode

Daniel Mack zonque at gmail.com
Thu Mar 27 11:26:36 CET 2014


Hi Peter,

On 03/27/2014 10:56 AM, Peter Ujfalusi wrote:
> On 03/27/2014 11:49 AM, Daniel Mack wrote:

>> +	u32 val = 0;
>> +	u8 *bytes = (u8*) &val;
> 
> Would it be better to call these variables as:
> u32 cs; /* as in Channel Status */
> u8 *cs_bytes = (u8*) &cs; /* Channel Status in bytes */
> 
> Without the comments of course.
> Sorry, I did not noticed this previously...

No problem. v3 coming up.

> Otherwise it looks good, does it work? ;)

It does! :)


Daniel



More information about the Alsa-devel mailing list