[alsa-devel] [PATCH v2] ASoC: rsnd: add DeviceTree support

Mark Brown broonie at kernel.org
Fri Mar 21 19:18:13 CET 2014

On Mon, Mar 17, 2014 at 07:29:55PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> Support for loading the Renesas R-Car sound driver via DeviceTree.

So, I've applied this but it needs some improvement - please do that
incrementally.  One thing you should have done here is CC the binding to
the DT list and maintainers for review.

> +- rcar_sound,ssi		: SSI subnode
> +- rcar_sound,scu		: SCU subnode
> +- rcar_sound,dai		: DAI subnode

This needs clearer documentation saying what the subnodes are - they're
actually collections of further nodes, each of which represents
something in the hardware.  The examples are fairly clear but the text
needs more than just "subnode".  Someone should be able to tell how to
write the DT just given the datasheet and this document.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140321/528df7f0/attachment.sig>

More information about the Alsa-devel mailing list