[alsa-devel] [PATCH] ALSA: compress: Pass through return value of open ops callback

Charles Keepax ckeepax at opensource.wolfsonmicro.com
Wed Mar 19 13:59:39 CET 2014

The snd_compr_open function would always return 0 even if the compressed
ops open function failed, obviously this is incorrect. Looks like this
was introduced by a small typo in:

commit a0830dbd4e42b38aefdf3fb61ba5019a1a99ea85
ALSA: Add a reference counter to card instance

This patch returns the value from the compressed op as it should.

Signed-off-by: Charles Keepax <ckeepax at opensource.wolfsonmicro.com>
 sound/core/compress_offload.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 7a20897..7403f34 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -133,7 +133,7 @@ static int snd_compr_open(struct inode *inode, struct file *f)
-	return 0;
+	return ret;
 static int snd_compr_free(struct inode *inode, struct file *f)

More information about the Alsa-devel mailing list