[alsa-devel] [PATCH 04/13] ASoC: Move IO functions to soc-io.c

Lars-Peter Clausen lars at metafoo.de
Wed Mar 19 12:47:59 CET 2014

On 03/19/2014 12:10 PM, Mark Brown wrote:
> On Tue, Mar 18, 2014 at 09:02:07AM +0100, Lars-Peter Clausen wrote:
>> soc-core.c is getting quite crowded. Move all IO related functions that are
>> still in soc-core.c to soc-io.c
> No, we're trying to make soc-io smaller!  Besides, if this stuff is
> getting cleaned up then:

We are trying to remove the ASoC level IO abstraction layer. In my opinion 
keeping everything related to this in one file, rather than hiding it among 
5k lines of other code, makes it clear what is still left to do.

>> -unsigned int snd_soc_read(struct snd_soc_codec *codec, unsigned int reg)
>> -{
>> -	unsigned int ret;
>> -
>> -	ret = codec->read(codec, reg);
>> -	dev_dbg(codec->dev, "read %x => %x\n", reg, ret);
>> -	trace_snd_soc_reg_read(codec, reg, ret);
>> -
>> -	return ret;
>> -}
>> -EXPORT_SYMBOL_GPL(snd_soc_read);
> ...making small things like this static inlines in a header is probably a
> better move (we can probably drop the trace - I don't think anything in
> active development doesn't use regmap and it's a carrot to push people).

Ok, if we don't care of about the traces I'll remove them and make the 
function static inlines.

- Lars

More information about the Alsa-devel mailing list