[alsa-devel] [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Mon Mar 10 03:25:02 CET 2014


> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -165,7 +165,7 @@ static int asoc_simple_card_parse_of(struct device_node
> *node,
>  	snd_soc_of_parse_card_name(&priv->snd_card, "simple-audio-card,name");
> 
>  	/* get CPU/CODEC common format via simple-audio-card,format */
> -	priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") &
> +	priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,format")


@Peter

Sorry, the interface of snd_soc_of_parse_daifmt(struct device_node *np,
const char *prefix), it's intended not only to parse the 'XXX,format', but also
'XXX,continuous-clock', 'XXX, bitclock-inversion', 'XXX, frame-inversion',
'XXX,bitclock-master' and 'XXX,frame-master' at the same time.

Maybe just the comment here is not very correct.

Thanks,

--
Best Regards,
Xiubo


> &
>  		(SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK);
> 
>  	/* off-codec widgets */
> --
> 1.9.0
> 
> 



More information about the Alsa-devel mailing list