[alsa-devel] [PATCH v5-resend 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec

Mark Brown broonie at kernel.org
Fri Mar 7 02:49:57 CET 2014

On Thu, Mar 06, 2014 at 05:51:43PM +0800, RongJun Ying wrote:
> 2014-03-06 17:20 GMT+08:00 Mark Brown <broonie at kernel.org>:

> > ...use devm_ioremap_resource() instead, please send a followup patch
> > fixing this.

> The i2s, internal audio codec and audio port use same register physics address
> and size. So if one driver use the devm_ioremap_resource instead.
> The other driver will invoke devm_ioremap_resource failed.

That's buggy - there should only be one device for each register range,
you should have a core MFD driver which gets the hardware resource and
shares the regmap with the client drivers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140307/dda733f8/attachment.sig>

More information about the Alsa-devel mailing list