[alsa-devel] [PATCH v4-resend 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec

Mark Brown broonie at kernel.org
Sat Mar 1 05:49:43 CET 2014

On Wed, Feb 26, 2014 at 03:22:17PM +0800, RongJun Ying wrote:

A couple of very small issues below but otherwise looks good.

> index d62ce48..23946c2 100644
> --- a/sound/soc/Kconfig
> +++ b/sound/soc/Kconfig
> @@ -54,6 +54,7 @@ source "sound/soc/spear/Kconfig"
>  source "sound/soc/tegra/Kconfig"
>  source "sound/soc/txx9/Kconfig"
>  source "sound/soc/ux500/Kconfig"
> +source "sound/soc/sirf/Kconfig"

Keep Kconfig and Makefile sorted.

> +static inline void sirf_audio_port_tx_enable(struct sirf_audio_port *port)

Drop the inlines, let the compiler do it if it decides it's worthwhile.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140301/01ad8846/attachment.sig>

More information about the Alsa-devel mailing list