[alsa-devel] [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree

Fabian Frederick fabf at skynet.be
Thu Jun 26 16:55:29 CEST 2014


Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Acked-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi at ti.com>
Cc: Jarkko Nikula <jarkko.nikula at bitmer.com>
Signed-off-by: Fabian Frederick <fabf at skynet.be>
---
 sound/soc/omap/mcbsp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 86c7538..68a1252 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
 	mcbsp->reg_cache = NULL;
 	spin_unlock(&mcbsp->lock);
 
-	if (reg_cache)
-		kfree(reg_cache);
+	kfree(reg_cache);
 }
 
 /*
-- 
1.8.4.5



More information about the Alsa-devel mailing list