[alsa-devel] alsa-tools 1.0.28 regression with sblive/emu10k1: init_live shell script broken.

[Clemens Ladisch]

Roc Vallès wrote:
> I've recently upgraded to alsa-tools 1.0.28. There's apparently a
> regression: live_init, the script that is bundled for sound blaster
> live soundcard initialization, has been broken.
>
> # /usr/bin/init_live
> /usr/bin/init_live: line 49: log: command not found
> /usr/bin/init_live: line 51: local: can only be used in a function
> ...

Broken by the patch below.  Where are the parentheses?


    commit a17282503f4ceb62f66eb5a28726fd096af0a70b
    Author: Elimar Riesebieter <riesebie at lxtec.de>
    Date:   Wed May 15 19:19:07 2013 +0200

    Fix bashisms.

    The "€œfunction"€ builtin is a bashism that can be simply omitted with
    no behaviour change, if parentheses are supplied.

    Signed-off-by: Jordi Mallach <jordi at debian.org>
    Signed-off-by: Takashi Iwai <tiwai at suse.de>

    diff --git a/ld10k1/setup/init_live.in b/ld10k1/setup/init_live.in
    index 70d30c8..5e6580f 100644
    --- a/ld10k1/setup/init_live.in
    +++ b/ld10k1/setup/init_live.in
    @@ -46,7 +46,7 @@ std_playback=playback
     std_capture=capture
     #std_capture=capture_noswitch

    -function log
    +log
     {
         local level=$1
    ...


Regards,
Clemens