[alsa-devel] [PATCH RFC/RFT] ASoC: rt5677: Convert to use rl6231_pll_calc

Oder Chiou oder_chiou at realtek.com
Mon Jun 23 07:32:29 CEST 2014


> -----Original Message-----
> From: Axel Lin [mailto:axel.lin at ingics.com]
> Sent: Tuesday, June 17, 2014 12:42 PM
> To: Mark Brown
> Cc: Oder Chiou; Liam Girdwood; alsa-devel at alsa-project.org
> Subject: [PATCH RFC/RFT] ASoC: rt5677: Convert to use rl6231_pll_calc
> 
> The implementation of rt5677_pll_calc() has the same logic of rl6231_pll_calc().
> The only difference is the lower boundary checking for freq_in.
> 
> This patch calls rl6231_pll_calc() instead of open-coded.
> The k_bp of struct rt5677_pll_code is always false, thus also remove the
> code to check pll_code.k_bp.
> 
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
Tested-by: Oder Chiou <oder_chiou at realtek.com>

> ---
> Hi Oder,
> This patch removes the usage of k_bp from struct rt5677_pll_code because it is
> always false. I think if k_bp is necessay in the further development, maybe
> it's better to add it to rl6231_pll_code. How do you think?
> 
It is the better way, thanks.



More information about the Alsa-devel mailing list