[alsa-devel] [PATCH 1/2] Revert "ALSA: hda - mask buggy stream DMA0 for Broadwell display controller"

[Yang, Libin]

Hi Takashi,

Got it. Thanks.

Regards,
Libin

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Monday, June 9, 2014 3:35 PM
> To: Yang, Libin
> Cc: alsa-devel at alsa-project.org; Lin, Mengdong
> Subject: Re: [PATCH 1/2] Revert "ALSA: hda - mask buggy stream DMA0 for
> Broadwell display controller"
> 
> At Mon,  9 Jun 2014 15:28:58 +0800,
> libin.yang at intel.com wrote:
> >
> > From: Libin Yang <libin.yang at intel.com>
> >
> > This reverts commit 7189eb9b8f7962474956196c301676470542f253.
> >
> > It will use LPIB to get the DMA position on Broadwell HDMI Audio.
> >
> > Signed-off-by: Libin Yang <libin.yang at intel.com>
> 
> Thanks, applied this with the next patch, but in a different order.
> In general, you shouldn't break things in the middle, especially for bisection.
> The second patch doesn't conflict with the DMA0 disablement, so we can
> apply it first, then revert DMA0 disablement.
> 
> 
> Takashi
> 
> > ---
> >  sound/pci/hda/hda_intel.c | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index cd77b9b..f93f338 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -1367,12 +1367,6 @@ static int azx_first_init(struct azx *chip)
> >  	/* initialize streams */
> >  	azx_init_stream(chip);
> >
> > -	/* workaround for Broadwell HDMI: the first stream is broken,
> > -	 * so mask it by keeping it as if opened
> > -	 */
> > -	if (pci->vendor == 0x8086 && pci->device == 0x160c)
> > -		chip->azx_dev[0].opened = 1;
> > -
> >  	/* initialize chip */
> >  	azx_init_pci(chip);
> >  	azx_init_chip(chip, (probe_only[dev] & 2) == 0);
> > --
> > 1.8.3.2
> >