[alsa-devel] [PATCH] sound: tlv320aic32x4: Fixed Coding style issues

[ShaRab Shaik]

​​
Hi Mark,

Sorry for the mistakes and thanks for the suggestions.
I will get back again with proper patches.


Thanks,
Shahina


On Wed, Jun 4, 2014 at 6:12 PM, Mark Brown <broonie at kernel.org> wrote:

> On Wed, Jun 04, 2014 at 04:49:54PM +0530, ShaRab Shaik wrote:
> > From 617d7a25f3c0c08e0b95b24de2d1ea0f3f4b98c7 Mon Sep 17 00:00:00 2001
> > From: Shahina Shaik <sharab.shaik at gmail.com>
> > Date: Wed, 4 Jun 2014 16:27:19 +0530
> > Subject: [PATCH] sound: tlv320aic32x4: Fixed Coding style issues.
> >
> > Fixed brace coding style, lines morethan 80 characters issues.
>
> Your patch appears to have been corrupted by your mailer, it's word
> wrapped so can't be applied by the tools.  Please see
> Documentation/SubmittingPatches and Documentation/email-clients.txt for
> some suggestions on how to set this up.
>
> > Replaced printk with pr_err as pr_err is prefered than printk.
>
> In general dev_err() is going to be usable by CODEC drivers and is even
> more strongly preferred than pr_err() since it provides more information
> about the source of the error.
>
> Please also avoid making multiple kinds of change in the same patch - it
> is much easier to review things if the patch is simpler.
>
> > -    if (aic32x4->power_cfg & AIC32X4_PWR_AVDD_DVDD_WEAK_DISABLE) {
> > +    if (aic32x4->power_cfg & AIC32X4_PWR_AVDD_DVDD_WEAK_DISABLE)
> >          snd_soc_write(codec, AIC32X4_PWRCFG, AIC32X4_AVDDWEAKDISABLE);
> > -    }
> > +
>
> So for example the print changes should be a separate patch to these
> brace  changes.  If you're removing the } you should also just delete
> the line.
>