[alsa-devel] Failed to set cache compression type

Mark Brown broonie at kernel.org
Mon Jun 2 17:09:57 CEST 2014


On Mon, Jun 02, 2014 at 05:02:50PM +0300, Jarkko Nikula wrote:

> I was looking at this too and it was introduced by the commit b59dce53ef61
> ("ASoC: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error.").

I've just fixed that now, the error checking isn't right - it should be
returning 0 not -EINVAL.

> If I understood commit 657254714ad2 ("ASoC: io: Remove support for ASoC
> cache in conjunction with regmap") right should we remove remaining
> soc-cache use? All codec drivers seems to include regmap.h although some of
> them are still calling soc_cache_sync().

There's still the AC'97 stuff at least, plus the ab8500 though if that
ends up blocking anything I'm just inclined to reapply the conversion
patch and let someone fix it if they care.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140602/b6ab37c9/attachment.sig>


More information about the Alsa-devel mailing list