[alsa-devel] [PATCH 1/1] ALSA: hda/realtek - Correction of fixup codes for PB V7900 laptop

[Takashi Iwai]

At Sun,  1 Jun 2014 18:38:53 +0200,
ronan.marquet at orange.fr wrote:
> 
> From: Ronan Marquet <ronan.marquet at orange.fr>
> 
> Correcion of wrong fixup entries add in commit ca8f0424 to replace
> static model quirk for PB V7900 laptop (will model).
> 
> Signed-off-by: Ronan Marquet <ronan.marquet at orange.fr>
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 49e884f..0e3a7f6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -1647,12 +1647,10 @@ static const struct hda_fixup alc260_fixups[] = {
>  	[ALC260_FIXUP_COEF] = {
>  		.type = HDA_FIXUP_VERBS,
>  		.v.verbs = (const struct hda_verb[]) {
> -			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x07 },
> -			{ 0x20, AC_VERB_SET_PROC_COEF,  0x3040 },
> +			{ 0x1a, AC_VERB_SET_COEF_INDEX, 0x07 },
> +			{ 0x1a, AC_VERB_SET_PROC_COEF,  0x3040 },

That part looks correct, however:

>  			{ }
>  		},
> -		.chained = true,
> -		.chain_id = ALC260_FIXUP_HP_PIN_0F,

Is this removal mandatory?  In other words, is keeping this harmful?
The original quirk had this, so it may be safer to keep it for other
machines.


thanks,

Takashi

>  	},
>  	[ALC260_FIXUP_GPIO1] = {
>  		.type = HDA_FIXUP_VERBS,
> -- 
> 2.0.0.rc2
>