[alsa-devel] [PATCH 1/2] ASoC: Add support for CS35L32 Boosted Amplifier

Mark Brown broonie at kernel.org
Thu Jul 31 22:27:18 CEST 2014


On Thu, Jul 31, 2014 at 03:27:13PM -0500, Brian Austin wrote:
> On Thu, 31 Jul 2014, Mark Brown wrote:

> > Should the interrupt and LED status registers not also be volatile?

> Sure. I guess precious doesn't have any effect on cache then?

It doesn't.

> > > +	case CS35L32_MCLK_6144MHZ:

> > Not sure these defines add anything over just using the numbers and it
> > avoids ickyness with the fact that I bet this isn't really 6.144GHz.

> I was trying to avoid using numbers, but if it is OK I can do that.

If the define just ends up shoving some characters in front of a number
it's not really adding anything.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140731/729490b8/attachment.sig>


More information about the Alsa-devel mailing list