[alsa-devel] [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver

Dmitry Torokhov dmitry.torokhov at gmail.com
Tue Jul 22 19:51:22 CEST 2014


On Tue, Jul 22, 2014 at 05:08:13PM +0200, Linus Walleij wrote:
> On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe <berthe.ab at gmail.com> wrote:
> 
> Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be
> applied. We're getting rid of the return value from gpiochip_remove().
> 
> > this remove all reference to gpio_remove retval in all driver
> > except pinctrl and gpio. the same thing is done for gpio and
> > pinctrl in two different patches.
> >
> > Signed-off-by: abdoulaye berthe <berthe.ab at gmail.com>
> (...)
> 
> I think this patch probably needs to be broken down per-subsystem as it
> hits all over the map. But let's start requesting ACKs for the
> individual pieces.
> Actually I think it will be OK to merge because there is likely not much churn
> around these code sites.
> 
> I'm a bit torn between just wanting a big patch for this hitting drivers/gpio
> and smaller patches hitting one subsystem at a time. We should be able
> to hammer this in one switch strike.

...

> 
> >  drivers/input/keyboard/adp5588-keys.c          |  4 +---
> >  drivers/input/keyboard/adp5589-keys.c          |  4 +---
> >  drivers/input/touchscreen/ad7879.c             | 10 +++-------
> 
> Dmitry can you ACK this?

Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>

-- 
Dmitry


More information about the Alsa-devel mailing list