[alsa-devel] [PATCH v2] ASoC: Intel: Add Broadwell Machine support

[Mark Brown]

On Mon, Jul 14, 2014 at 10:35:40AM +0800, Jie Yang wrote:
> From: Liam Girdwood <liam.r.girdwood at linux.intel.com>
> 
> Add support for Broadwell based machines with SST DSP audio.

Applied, one tiny thing though:

> +static int broadwell_rt286_hw_params(struct snd_pcm_substream *substream,
> +	struct snd_pcm_hw_params *params)
> +{
> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +	struct snd_soc_dai *codec_dai = rtd->codec_dai;
> +	int ret;
> +
> +	ret = snd_soc_dai_set_sysclk(codec_dai, RT286_SCLK_S_PLL, 24000000,
> +		SND_SOC_CLOCK_IN);
> +
> +	if (ret < 0) {
> +		dev_err(rtd->dev, "can't set codec sysclk configuration\n");
> +		return ret;
> +	}

Since this is left the same all the time it'd be better to set it in
rtd_init() or a late_probe() callback rather than resetting it each
time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140716/8080f714/attachment.sig>