[alsa-devel] [PATCH 2/2] ASoC: arizona: Improve ultrasonic frequency response

[Mark Brown]

On Fri, Jan 31, 2014 at 03:47:14PM +0000, Charles Keepax wrote:
> Evaluation of the device has given some settings to improve the
> ultrasonic frequency response. This patch allows the user the option of
> applying those.

Why would the user ever not want to do this?

> +	switch (priv->arizona->type) {
> +	case WM5102:
> +		if (priv->arizona->pdata.ultrasonic_response) {
> +			snd_soc_write(codec, 0x80, 0x3);
> +			if (params_rate(params) >= 176400)
> +				snd_soc_write(codec, 0x4dd, 0x1);
> +			else
> +				snd_soc_write(codec, 0x4dd, 0x0);
> +			snd_soc_write(codec, 0x80, 0x0);
> +		}
> +		break;

The code is only changing the configuration when the user is actually
using ultrasonic sample rates so it doesn't seem like it should have a
detrimental effect on other configurations.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140131/93e531de/attachment.sig>