[alsa-devel] [PATCH 2/3] ASoC: atmel_wm8904: make it available to choose clock
broonie at kernel.org
Mon Jan 27 21:59:25 CET 2014
On Thu, Jan 16, 2014 at 09:31:23AM +0800, Bo Shen wrote:
> >Shouldn't this code be in the DAI driver? Otherwise this series looks
> >fine to me, though the DT folks might have something to say I guess.
> For audio on Atmel SoC, it depends on three device nodes, one is
> SSC node, one is the codec node and the sound node.
> The sound node will parse by machine driver, and machine driver is
> mainly for hardware connection. As the "clk_from_rk_pin" is decided
> by hardware, so, I put it here.
> If I move the code to dai driver, it will parse the sound node in
> dai driver, I think it will make the code a little bit not explicit.
> What do you think?
I think it should just be a property of the DAI device. It's true that
the card defines the connections but if something is going to be an
option that's there for most if not all systems then putting it in the
device driver means less effort on each integration.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel