[alsa-devel] [PATCH v4 07/19] ALSA: Oxygen: Add new CS4245 SPI functions

[Clemens Ladisch]

Mark Brown wrote:
> On Fri, Jan 24, 2014 at 04:18:08PM +0400, Roman Volkov wrote:
>> Add the new SPI write and read functions. The SPI read function
>> is used for creating initial registers dump and may be used for
>> debugging purposes. SPI operations are cached, so there is a new
>> function to manage the cache (shadow). I have to remove
>> the shift from the CS4245_SPI_* constants, since when
>> we are performing the reading, we need to shift by 8 instead
>> of 16.
>
> I can't help but think that this driver ought to be making more use of
> frameworks

Everbody else thinks the same: <http://lkml.org/lkml/2012/3/13/215>.

Unfortunately, thinking requires less effort than writing patches.


Regards,
Clemens