[alsa-devel] [PATCH v2 1/4] ASoC: tlv320aic32x4: Use signed int mixer controls

Mark Brown broonie at kernel.org
Tue Jan 21 22:14:55 CET 2014

On Mon, Jan 20, 2014 at 01:05:55PM +0100, Markus Pargmann wrote:

> +	SOC_DOUBLE_R_S_TLV("PCM Playback Volume", AIC32X4_LDACVOL,
> +			AIC32X4_RDACVOL, 0, (s8)0x81, 0x30, 7, 0, tlv_pcm),

These casts are icky - I'd expect either signed numbers being used here
or the macros to deal with any required casting.  On the other hand
there's fun and games with the type sizes...

Also this seems to depend on the patch series adding these controls,
please note such dependencies when submitting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20140121/4e67b191/attachment.sig>

More information about the Alsa-devel mailing list