[alsa-devel] [PATCH v3 04/16] ALSA: Oxygen: Add CS4245_SPI_READ constant

Clemens Ladisch clemens at ladisch.de
Sat Jan 18 11:29:36 CET 2014

Roman Volkov wrote:
> The driver needs this constant to perform SPI read operations.
> The shift from CS4245_SPI_ADDRESS and CS4245_SPI_WRITE constants
> removed, since when we need to send two bytes instead of three
> in the SPI packet, we need to shift left by 8 instead of 16.
> -#define CS4245_SPI_ADDRESS	(0x9e << 16)
> -#define CS4245_SPI_WRITE	(0 << 16)
> +#define CS4245_SPI_ADDRESS	0x9e
> +#define CS4245_SPI_WRITE	0

This change alone breaks the driver.

All patches must be self-contained, which is important to be able to
apply the patch series partially during debugging.

Please merge this with the patch that changes the SPI code.


More information about the Alsa-devel mailing list