[alsa-devel] [RFC][PATCH] ASoC: simple-card: Add asoc_simple_card_data for the simple card driver data
moinejf at free.fr
Tue Jan 14 12:09:13 CET 2014
On Tue, 14 Jan 2014 07:56:32 +0000
"Li.Xiubo at freescale.com" <Li.Xiubo at freescale.com> wrote:
> > > Whether the dt is used or not, almost all the simple card information
> > > for the DAI link and sound card are initialized in the simple card driver.
> > >
> > > And for the platform caller, the snd_link and snd_card are of no use, so
> > > move them from struct asoc_simple_card_info to struct asoc_simple_card_data.
> > >
> > > And now only one DAI link is supported for simple card.
> > >
> > > Suggested-by: Jean-Francois Moine <moinejf at free.fr>
> > > Signed-off-by: Xiubo Li <Li.Xiubo at freescale.com>
> > > ---
> > This patch seems have many this kind of lines
> > - info->xxx
> > + sdata->info->xxx
> > But, how about add this line to each function ?
> > struct asoc_simple_card_info *info = &sdata->info;
> > Patch will be more readable
> Yes, that's looks perfect.
> See the next version please.
Please, don't work on an other version. I am preparing an other patch which will do quite the same as yours, but which will be easier to extend to many DAI links.
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
More information about the Alsa-devel